util: handle symbols properly in format()#931
Closed
cjihrig wants to merge 1 commit intonodejs:v1.xfrom
cjihrig:927
Closed
util: handle symbols properly in format()#931cjihrig wants to merge 1 commit intonodejs:v1.xfrom cjihrig:927
cjihrig wants to merge 1 commit intonodejs:v1.xfrom
cjihrig:927
Conversation
Currently, if util.format() is called with a string as its first argument, and a Symbol as one of the subsequent arguments, an exception is thrown due to an attempted implicit string conversion. This commit causes Symbols to be explicitly converted.
Contributor
|
LGTM |
cjihrig
added a commit
that referenced
this pull request
Feb 24, 2015
Currently, if util.format() is called with a string as its first argument, and a Symbol as one of the subsequent arguments, an exception is thrown due to an attempted implicit string conversion. This commit causes Symbols to be explicitly converted. Fixes: #927 PR-URL: #931 Reviewed-By: Domenic Denicola <domenic@domenicdenicola.com>
Contributor
Author
|
Landed in ed3b057 |
This was referenced Feb 24, 2015
petkaantonov
pushed a commit
to petkaantonov/io.js
that referenced
this pull request
Feb 25, 2015
Currently, if util.format() is called with a string as its first argument, and a Symbol as one of the subsequent arguments, an exception is thrown due to an attempted implicit string conversion. This commit causes Symbols to be explicitly converted. Fixes: nodejs#927 PR-URL: nodejs#931 Reviewed-By: Domenic Denicola <domenic@domenicdenicola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if
util.format()is called with a string as its first argument, and a Symbol as one of the subsequent arguments, an exception is thrown due to an attempted implicit string conversion. This commit causes Symbols to be explicitly converted.This bug is due to a discrepancy between how the docs say
util.format()work, and what really happens. The docs state:However, only objects actually use
util.inspect(). I think we should bring behavior into line with what the docs say, but this is a slightly breaking change.Closes #927. R=@domenic